fix?: enforce flow shift for all schedulers#1697
Conversation
|
Thanks for looking into this, but I don't think this is the right fix. The current distinction between scheduler types is intentional: timestep-space schedulers call This is also not equivalent to diffusers' FlowMatch scheduler behavior with Karras sigmas. Diffusers applies dynamic shifting before the ptional Karras conversion, then Karras rebuilds the schedule from the shifted endpoints. This PR instead warps every generated sigma after the cheduler has already constructed its curve, which changes the intermediate points in a different way. So I don't think we should merge this global post-processing approach. If we want diffusers-like behavior for Karras, it should be implemented in the scheduler-specific path by shifting the endpoint range before Karras reconstruction, not by warping all scheduler outputs afterward. |
|
I get your point and you're probably right. But on the other hand, this makes the flow-shift parameter silently innefective with a lot of schedulers, which might feel inconsistent and confusing for users who don't care about the implementation details of the schedulers nor strict compatibility with diffusers. |
|
I understand the concern, but I don't think this UX inconsistency is a problem we should solve at this level. For most users, schedulers are already black-box sampling strategies. For sigma-space schedulers, the schedule itself is the definition of the sigma curve. Applying an element-wise shift after the scheduler has generated that curve changes the scheduler's meaning. So I think we should keep the current behavior: timestep-space schedulers apply flow shift through |
Summary
Applies flow-shift even on sigma-space schedulers.
Related Issue / Discussion
#1669
Additional Information
Example: bong_tangent scheduler (sigma-space)
sd-cli.exe --diffusion-model ..\ComfyUI\models\unet\z_image_turbo-Q8_0.gguf --vae ..\ComfyUI\models\vae\flux\ae.safetensors --llm ..\ComfyUI\models\clip\llms\Qwen3-4b.Q6_K.gguf --cfg-scale 1.0 -v --offload-to-cpu --preview proj --steps 8 --rng cpu --lora-model-dir H:\ComfyUI\models\loras\z-img -W 1024 -H 1024 --color --vae-conv-direct --sampling-method res_2s -p "A lovely cat holding a small 16:9 picture frame" --scheduler bong_tangent --flow-shift [x]`
smoothstep scheduler (timestep-space)
Checklist